Potential fix for code scanning alert no. 13: Uncontrolled command line#21
Merged
Rootless-Ghost merged 1 commit intomainfrom Apr 26, 2026
Merged
Potential fix for code scanning alert no. 13: Uncontrolled command line#21Rootless-Ghost merged 1 commit intomainfrom
Rootless-Ghost merged 1 commit intomainfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/AtomicLoop/security/code-scanning/13
General fix: ensure any user-influenced command-line argument is strictly validated and canonicalized immediately before process execution, and fail closed if it does not match a narrow allowed format.
Best fix here (without changing functionality): in
core/remote_executor.py, add a final defensive validation step right before buildingcmd_list, using a dedicated helper that only accepts canonical IPv4/IPv6 literals or RFC1123-style hostnames, then use that sanitized value incmd_list. This keeps current behavior (valid hosts still work) while making the trust boundary explicit at sink proximity.Changes needed:
core/remote_executor.py_HOST_RE) that validates a host string and returns a safe canonical value (or raises/returns failure).target_host = normalized_hostusage withsafe_target_host = ...from that helper.safe_target_hostin both Windows and non-Windowscmd_listdefinitions and logging.Suggested fixes powered by Copilot Autofix. Review carefully before merging.